Eranziel / foundryvtt-lancer

A Foundry VTT game system for LANCER RPG.
GNU General Public License v3.0
105 stars 63 forks source link

[BUG] Player Deployables are not automatically created on mech import #738

Open DCShank opened 2 months ago

DCShank commented 2 months ago

Describe the bug When a player creates their pilot and syncs with Comp/Con to import their mech, instead of automatically creating actors for their deployables, it sends messages in the chat visible to both the GM and the Player with a button that says "IMPORT [name of deployable] FOR [name of mech]?". Clicking the button creates the deployable.

To Reproduce Steps to reproduce the behavior:

  1. Configure Players to be allowed to create actors
  2. Create a Player
  3. Login as the Player (Remaining steps are from the players user)
  4. Login to Comp/Con
  5. Create a Pilot Actor
  6. Sync your pilot to a mech in Comp/Con

Expected behavior The mech and deployables are automatically imported from Comp/Con

Screenshots image

Platform (please complete the following information):

Additional context Performing the same steps as a GM creates the deployables automatically. The buttons and messages are visible to both the player and the gm, and either clicking the button creates the deployable and deletes the message.

Discord contact info dcshank

Eranziel commented 2 months ago

That is intentional. It circumvents a few tricky bugs that can happen when player clients try to create actors.

I'll leave this issue open for a bit in case someone else on the team wants to tackle it, but this is probably a won't-fix

BoltsJ commented 2 months ago

What's different for the deployables compared to mechs? I was under the impression that mechs get created just fine?