[BUG] NPCs with Legendary suffer a Crushing Hit instead of Direct Hit

[tw-blob]

Describe the bug An NPC with Legendary and two or more structure remaining can roll a Crushing hit result. This happens when they roll two ones on the separate structure rolls grated by Legendary.

To Reproduce

• create an NPC with the legendary trait and at least 3 structure
• set the hp to zero and roll the structure damage
• reset the current structure to at least 3 if you don't get two ones on separate rolls
• if you roll two ones it reports a Crushing Hit instead of the expected Direct Hit

Expected behavior A mech that has 2 or more structure remaining should get a Direct Hit result when rolling a one on the Structure Table. An NPC with the Legendary trait should discard one of the rolls resulting in the same result as a mech without the trait.

Screenshots Same mech with and without the Legendary trait.

Platform (please complete the following information): Foundry Virtual Tabletop: Version 11 Stable, 11.315 Game System: lancer, 2.2.4 Active Modules: 0

Discord contact info .lopeck.

[Eranziel]

I've figured out an almost-complete solution for this.

Unfortunately Foundry will still occasionally pick the less favourable result. For example, if you roll [1,2] and [1,1] in that order, Foundry will pick the 2nd result to keep, which ends up evaluating as a Crushing Hit instead of Direct Hit.

We'll just have to live with that foible for now, because forcing the Roll object to select the other result would be quite involved. I'll leave this issue open for follow-up, maybe it will become easier in the future.

[aWinglessMonkey]

The solution to this is in the description for "Legendary" itself, specifically the last few words:

The Ultra/Veteran rolls all structure damage and overheating checks twice and chooses either result.

This is a choice, it is not at all a simple monotonic function (particularly with structure rolls, Ultras, and their Juggernaut feature), and the GM has further considerations beyond "optimal" (such as game health) when choosing.

Streamlining a choice is good - for example rolling and displaying two separate checks automatically - but please do not automate the choice out. Automating past decision-points is how we got #379, which has been my biggest frustration-point with this system of late, and which I have been very glad to see is nearly solved.