search

ErdbeerbaerLP / DiscordIntegration-Core

Common module for the Discord Integration mod
https://modrinth.com/plugin/dcintegration
4 stars 21 forks source link

Bump net.dv8tion:JDA from 5.0.0-beta.17 to 5.0.0-beta.18 #161

Closed dependabot[bot] closed 11 months ago

dependabot[bot] commented 11 months ago

Bumps net.dv8tion:JDA from 5.0.0-beta.17 to 5.0.0-beta.18.

Release notes

Sourced from net.dv8tion:JDA's releases.

v5.0.0-beta.18

Overview

This release fixes a race-condition in the default rate-limiter implementation that very rarely resulted in an orphaned rate-limit bucket.

Orphan Rate-Limit Buckets (#2585)

Sometimes the cleanup of buckets resulted in an active rate-limit bucket being orphaned. This means that the bucket was continuously trying to execute the same request without updating its state.

This release should resolve that problem, fixing the occasional bug where a 429 response was handled incorrectly.

New Thread Model (#2463)

The default thread model used for the handling of rate-limits has been changed. Instead of using a single scheduled executor, we now make use of an additional elastic pool that automatically scales up and down based on how many buckets run concurrently.

In the previous model, the scheduled executor limited the capabilities by only providing a fixed amount of threads. To handle scaling with larger bots, we simply used 5 threads for each shard. This has been adjusted now to use a shared pool, which scales up and down based on load instead.

Please let us know if you run into any problems with the defaults in your deployments!

New Features

Changes

Bug Fixes

Full Changelog: https://github.com/discord-jda/JDA/compare/v5.0.0-beta.17...v5.0.0-beta.18

Installation

Gradle

repositories {
    mavenCentral()
}
dependencies {
    implementation("net.dv8tion:JDA:5.0.0-beta.18")
}

Maven

... (truncated)

Commits
  • cfbace6 Bump to 5.0.0-beta.18
  • 136aa91 Change thread model used for requests (#2463)
  • 239288f Fix incorrect index used in attachment update requests (#2588)
  • 9a55479 Fix orphaned rate-limit buckets (#2585)
  • 8937fd4 Add support for resetting min/max length in TextInput.Builder (#2584)
  • b7937d0 Remove outdated todo comments and update outdated logic in thread channels (#...
  • See full diff in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
dependabot[bot] commented 11 months ago

Looks like net.dv8tion:JDA is up-to-date now, so this is no longer needed.