search

ErdbeerbaerLP / DiscordIntegration-Forge

Forge version of the Discord Integration mod
https://modrinth.com/plugin/dcintegration
MIT License
100 stars 55 forks source link

Rate limits during server startup/shutdown #235

Closed Derkades closed 3 years ago

Derkades commented 3 years ago

The mod works almost perfectly, except it extends server startup and shutdown by 5+ minutes while spewing rate limit messages to the console WARN RateLimiter - Encountered 429 on route

Version

Platform

Mod version:

Config file

https://paste.derkad.es/pebuqahifi.toml

Derkades commented 3 years ago

I have a feeling it's related to updating channel descriptions during startup/shutdown, when it's also updating periodically the rate limit of 2 in 10 minutes can be reached.

My attempt to test this by compiling from master with that commented out failed with the following error (jar generated by ./gradlew build, no forge experience)

Caused by: java.lang.SecurityException: class "org.spongepowered.asm.service.ServiceInitialisationException"'s signer information does not match signer information of other classes in the same package
    at java.lang.ClassLoader.checkCerts(ClassLoader.java:891)
    at java.lang.ClassLoader.preDefineClass(ClassLoader.java:661)
    at java.lang.ClassLoader.defineClass(ClassLoader.java:754)
    at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
    at java.net.URLClassLoader.defineClass(URLClassLoader.java:468)
    at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
    at java.net.URLClassLoader$1.run(URLClassLoader.java:369)
    at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
    at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
    at java.lang.Class.getDeclaredConstructors0(Native Method)
    at java.lang.Class.privateGetDeclaredConstructors(Class.java:2671)
    at java.lang.Class.getConstructor0(Class.java:3075)
    at java.lang.Class.newInstance(Class.java:412)
    at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:380)
    ... 24 more
Derkades commented 3 years ago

Rate limit issues are gone with B:MODIFY_CHANNEL_DESCRIPTRION=false

ErdbeerbaerLP commented 3 years ago

This feature is no longer supported because discord increased the rate limit way to high for this feature