search

ErdbeerbaerLP / DiscordIntegration-Forge

Forge version of the Discord Integration mod
https://modrinth.com/plugin/dcintegration
MIT License
99 stars 56 forks source link

[Bug]: IllegalArgumentException crashes server in genItemStackEmbedIfAvailable in dcintegration:2.1.1 #361

Open klugemonkey opened 2 years ago

klugemonkey commented 2 years ago

What happened?

genItemStackEmbedIfAvailable was called in the handling of LivingDeathEvent and tried to parse an item's tag data resulting in an IllegalArgumentException being thrown which was not handled gracefully causing forge to crash.

The item that the mob used to kill the player had tag data from the Apotheosis mod which may/or may not have been properly formatted, but nonetheless, failed to parse.

The death message occurred before any grave plugin could handle player drops resulting in permanent loss of player data on restart.

Game Version

1.16

What platform are you using?

Forge

Platform version

forge-36.2.4

Config File

https://pastebin.com/estqGb2M

Crash report / Error log (if applicable)

https://pastebin.com/iiMSk1a3

Additional Information

Java 1.8.0_282

ErdbeerbaerLP commented 2 years ago

still happening with latest version? (2.3.5 for 1.16/ 1.17/1.18)