ErdbeerbaerLP / DiscordIntegration-Forge

Forge version of the Discord Integration mod
https://modrinth.com/plugin/dcintegration
MIT License
99 stars 54 forks source link

[Bug]: Making serverStarting blank causes bot to crash instead of stop the message from being sent #462

Open RandomGgames opened 2 years ago

RandomGgames commented 2 years ago

What happened?

Setting serverStarting to "" causes bot to not work at all. Probably happens with the other auto-messages if I had to guess.

To fix, best two options would be to check if "" and just disable, or add a dedicated true/false option for enabling these messages.

Game Version

1.19

What platform are you using?

Fabric

Platform version

2.4.5

Config File

# This message will edited in / sent when the server finished starting
serverStarted = ""
# Message to show while the server is starting
# This will be edited to SERVER_STARTED_MSG when webhook is false
serverStarting = ""
# This message will be sent when the server was stopped
serverStopped = ""
# The message to print to discord when it was possible to detect a server crash
serverCrash = "Server Crash Detected :thinking:"
github-actions[bot] commented 1 year ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days

RandomGgames commented 1 year ago

if this is still an issue, than should be fixed. I haven't looked at it in a while.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days