search

ErdemOzgen / blackdagger

Blackdagger is a DAG-based automation tool specifically used in DevOps, DevSecOps, MLOps, MLSecOps, and Continuous Red Teaming (CART).
https://blackdagger.readthedocs.io/
GNU General Public License v3.0
48 stars 8 forks source link

DAGs not stopping when Blackdagger is interrupted #40

Open akindemirsec opened 7 months ago

akindemirsec commented 7 months ago

I created a simple DAG and this DAG creates a file every 5 seconds. However, I noticed that the DAGs do not stop when Blackdagger is interrupted.

I have attached the files where the problem occurs as attachments below:

image (the DAG file) https://github.com/ErdemOzgen/blackdagger/assets/128565483/2b29fb07-8df5-47f1-bb05-23d3b8ea0540 (video)

ataseren commented 4 months ago

This is probably caused by Blackdagger not sending a stop signal to each active DAG's. I'll also test it with continuously running DAG's such as GoTTY DAG and start working on it, thanks @akindemirsec

EDIT: I tested it with GoTTY DAG too and encountered same case. Stopping all running DAG's when server stopper signal is received will probably solve the issue.