search

EricBerendsen / dvbinspector

DVB Inspector is an open-source DVB analyzer, written in java
http://www.digitalekabeltelevisie.nl/dvb_inspector/
GNU General Public License v3.0
174 stars 30 forks source link

EBU subtitles. #19

Open a4x4kiwi opened 3 years ago

a4x4kiwi commented 3 years ago

Hi Eric,

There has been quite some interest, and an attempt to include EBU subtitles into Googles Exoplayer app. https://github.com/google/ExoPlayer/issues/5491 among others.

The previous effort was in native code C, is buggy and can not be integrated into Exo.

I was wondering if you might be interested in making a library or module for integration into the Exoplayer project. The specific skills seem to be very scarce so thought I would reach out to you as you are very experienced in this area.

If course I can assist with testing and providing any TS samples from Australian TV you may require.

Thanks for your consideration.

All the best, Mal.

lars18th commented 3 years ago

Hi @EricBerendsen ,

I'm the gay that has suggested to reuse part of your code. Please, let me to explain the idea: As the current DVBInspector implementation has included the decoding of the TELETEXT SUBTITLES, and the project is writen in Java (and very good architectured), the question is: You think it will be possible to adapt an encapsulated Java class with this functionality? Other people in the ExoPlayer project will do the work to use this class in the player. But two questions remains: First, if you agree with the idea of "reuse" some of your code for this objective. Second, if you can help (not much) to define this concrete reusable class or not.

Please, explain your opinion. I don't want to be rude or pressure you to accept this idea. I'm not affiliated in any sense with the ExoPlayer project. I'm only a user/developer that I suggested to @a4x4kiwi to reuse part of your code, as hi has integrated initially some support in the ExoPlayer project.

I hope this can help. Regards.

EricBerendsen commented 3 years ago

I have no problems with re-use of (parts of) DVB Inspector code in other open source projects.

The code for teletext support might be a good starting point for integrating EBU subtitles into Googles Exoplayer app. However it will require some major changes. DVB Inspector first loads the entire teletext stream into memory before presenting any info and or images. That will not work for a media player, so a complete change of structure is needed.

I think I would not be the best person to create a module for exoplayer. I don't know anything about android, or mediaplayers. Of course I am willing to help and answer any questions (If I can remember, that part of the code is almost 9 years old now....).

a4x4kiwi commented 3 years ago

Thanks Eric,

I (we) appreciate being able to reuse code. Yes, It will require quite some integration for real-time processing.

All the best.