Closed lars18th closed 2 years ago
Hi @lars18th
I understand the issue. Must admit I did not test the table views with multiple versions of PAT/SDT, etc.
At the moment the tables show the view of the first (oldest) version of the data. That is a consistent view of the data at that moment. Showing a "merged" version would show something that never occurred. Then you would have to somehow mark rows as deleted or new. (I did something like that here. It was not easy.)
It would be even more complicated for all the possible changes for all types of tables.
Still it is worth playing around with. Do you have some test streams available?
Hi @EricBerendsen ,
Still it is worth playing around with. Do you have some test streams available?
My test streams are synthetic streams manipulated with the TSDuck toolkit. However, if you need one then I can prepare one to share with you.
It would be even more complicated for all the possible changes for all types of tables.
Yes, I feel it's not necessary to complicate a lot the code for a small advantage. However, in order to handle such cases I have one simple proposal:
With this support you can use by default the older version (as now). But the user can then enforce to use the never version. And then all parts of the tool will use the information selected. This will include the names of the services, for example if the SDT table is updated. But will be also true for any other PSI table. I feel this is sufficient easy to implement it, and at the same time sufficient powerful. What you think?
First a remark in general about my design philosophy for DVB inspector. In the Tree view the left panel (the tree) should represent the whole, consistent, actual and complete data. What is displayed in the right panel can be a summary, clarification, visualisation or other interpretation of the data. When in doubt, look at the tree, not at the right panel.
The views in the right panel will not always be complete. Example: a table of the components in a PMT will not show all info about the components, just a few selected descriptors are used for creating the table.
The table shown for the PAT shows service names. These are found in the SDT, but put here for easier reading.
The views for the EIT do not take into account version updates (and for EIT version updates are the most likely).
For other tables a version update is a edge case. It is not very likely to happen. But when you go down the rabbit hole of supporting multiple versions (outside of the tree), there are a lot of possible complications. What if you have some sections of the old version, and other sections of the new version? When a services is renamed in the SDT, the SDT should have two versions. But the PAT table also shows service names for easy reading. Should that table also reflect the update in the SDT?
It would not be possible to create a general solution to support multiple versions for all tables. The table view for each PSI table has its own specialised coded, which is complex enough as it is.
I don't think this edge case is worth the extensive effort.
Ok. Thank you for the answer.
Hi @EricBerendsen ,
I detected a very small (but not simple) bug:
Therefore I feel you need to update the data when a new version of the tables appears. And the issue is complex to fix it because it's not sufficient to use the las table. For example, perhaps a service is removed (not added). So in this case you need to "merge" more or less the new with the old data.
Perhaps you never have seen this. But it can appear and I want to report it. Regards.