search

EricBerendsen / dvbinspector

DVB Inspector is an open-source DVB analyzer, written in java
http://www.digitalekabeltelevisie.nl/dvb_inspector/
GNU General Public License v3.0
175 stars 30 forks source link

Crash in JPEG XS descriptor handler #54

Closed efykse closed 1 year ago

efykse commented 1 year ago

DVB Inspector 1.17.0 is crashing when analyzing the PMT in this TS recording: xs_descriptor.zip

It seems maybe it is expecting some private byte at the end of the descriptor, but as far as I know this is optional.

SEVERE: Error displaying stream
java.lang.NullPointerException: Cannot read the array length because "value" is null
        at nl.digitalekabeltelevisie.controller.KVP.<init>(KVP.java:223)
        at nl.digitalekabeltelevisie.data.mpeg.descriptors.extension.mpeg.JpegXsVideoDescriptor.getJTreeNode(JpegXsVideoDescriptor.java:105)
        at nl.digitalekabeltelevisie.util.Utils.addToList(Utils.java:1223)
        at nl.digitalekabeltelevisie.util.Utils.addListJTree(Utils.java:1202)
...
EricBerendsen commented 1 year ago

Thanks for reporting this. You are completely right, the private bytes are optional. Fixed now, if you need a snapshot version with the fix included you can find it at the actions tab