EricGuo5513
commented
2 weeks ago Hi, thanks for pointing out this. The first one seems a bug exactly. I guess it’s not major problem, but it may still cause few discontinuities for root angle. However since many experiments have been done on this version, I could not update this anymore. I will highlight this issue to note others. For the second one, as long as you keep the same rule when you extract features and recovering motions, it should be fine.
In the 58th line of common/skeleton.py, the order of "l_hip, r_hip, sdr_r, sdr_l = face_joint_idx" is different from the comment "right hip, left hip, right shoulder, left shoulder", whether this will influence the processed data?
Meanwhile, in the 74th line of the common/skeleton.py, "root_quat = qbetween_np(forward, target)" is the rotation from forward to the [0,0,1], whether it should be the rotation from [0,0,1] to the forward?