the validation set should be used instead of the test set in train_vq.py

EricGuo5513 / momask-codes

Official implementation of "MoMask: Generative Masked Modeling of 3D Human Motions (CVPR2024)"

https://ericguo5513.github.io/momask/

MIT License

690 stars 56 forks source link

Closed fanqinshan0114 closed 1 month ago

fanqinshan0114 commented 1 month ago

It seems that in train_vq.py the validation set should be used instead of the test set to save the best fid model?

Murrol commented 1 month ago

Hi,

You are right! It's probably a problem left over from some RVQ ablation experiments. We have fixed it. Thanks.