search

EricSSartorius / Judging-System

U-Judge: Universal Judging System using Angular Meteor (OLD)
http://www.universaljudge.com/
1 stars 1 forks source link

Create Event - Email notifications #56

Open EricSSartorius opened 8 years ago

EricSSartorius commented 8 years ago

When the admin creates a judge in the event creation process, if there is no existing email then the email address should be notified that the person has been appointed as a judge and needs to click a link to confirm.

felicedeNigris commented 8 years ago

I got this one!

felicedeNigris commented 8 years ago

Hey Eric, so If admin creates a judge with no email, the admin is appointed judge?

EricSSartorius commented 8 years ago

If the email that the judge appointed is already tied to a registered account, that account will get an email telling them they have been appointed a judge for X event.

If the admin tries to appoint a judge's email address to an email that does not have a registered account, I guess we have 2 options, not sure which would work better.

  1. Give the person creating an event a notification that says there is no current account with that email.
  2. Notify the person creating the event that there is no current account with that email but that the email address has been notified to create an account for event. And then send an email to the address that was added as a judge telling them to sign up for an account if they want to judge.
felicedeNigris commented 8 years ago

Hmm. I like the first one better. Just because it might be weird if people got emails from Ujudge not knowing they were involved. Of course that's my opinion.

EricSSartorius commented 8 years ago

I agree

felicedeNigris commented 8 years ago

Okay I think this issue is solved. You may have to tweak it though, because the way Email.send works is that you need a real from email. So I don't know if you can create one from your meteor host or just create a gmail accout for ujudge ? It still works the way it is but it might be blocked from spam filters. I added check package and email package to get this to work. Let me know what you think.

EricSSartorius commented 8 years ago

I am getting a notification now that the email I am trying to use for a judge is not registered with Ujudge even though I have made an account with the email address. Once this is solved then I can close this issue. Good work on everything though!