search

EricSmekens / jsep

JavaScript Expression Parser
http://ericsmekens.github.io/jsep/
MIT License
836 stars 136 forks source link

Include typings in all builds. Update base Expression type #174

Closed 6utt3rfly closed 3 years ago

6utt3rfly commented 3 years ago

160 - include types in all package builds (my fault - sorry!)

173 - Remove LogicalExpression type from types

91 - update base Expression type. To ensure compatibility with plugins, rather than renaming Expression to BaseExpression, I added the discriminated union discussed as CoreExpression and made the base Expression more generic, so the type can be any string (allows for extending by plugins without having to use ), and provides [key: string]: ...

I'm open to alternative suggestions as well

EricSmekens commented 3 years ago

Looks good! Do you wish to release this in a 1.0.2 to quickly resolve the feedback in 160? (If you add a changelog and package.json update, I will make a tag+release).

6utt3rfly commented 3 years ago

@EricSmekens - I've updated the package versions and changelog files. Can we include #176 in the @jsep-plugin/assignment release?

github-actions[bot] commented 3 years ago

:tada: This PR is included in version @jsep-plugin/ternary-v1.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: