fix: firefox compatibility

EricSmekens / jsep

JavaScript Expression Parser

http://ericsmekens.github.io/jsep/

MIT License

836 stars 136 forks source link

fix: firefox compatibility #179

Closed 6utt3rfly closed 3 years ago

6utt3rfly commented 3 years ago

When copying from the static class methods to the jsep function, don't rely on the ordering of keys. Instead, check for properties that are allowed to be set (![prototype, name, length]), by checking if they already exist on jsep. This fixes the "length" is readonly error in firefox (but works in Chrome/Node)

Fixes #178

6utt3rfly commented 3 years ago

@EricSmekens - would you like to try the CI build (#177 ) for this?

EricSmekens commented 3 years ago

I'm quite busy until after this weekend, so you have my permission to try this out of you want to. If you need some help on the permission side, let me know, otherwise I can pick this up and try it out after this weekend.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.0.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: