search

EricSmekens / jsep

JavaScript Expression Parser
http://ericsmekens.github.io/jsep/
MIT License
835 stars 136 forks source link

warning Workspaces can only be enabled in private projects #218

Closed rathpc closed 2 years ago

rathpc commented 2 years ago

I stumbled on this issue due to using another package that has jsep as a deeply nested dependency.

When running any yarn command (install, build etc.) many warnings are spit out that say the following:

warning Workspaces can only be enabled in private projects.

This is due to jsep having "private": false in the package.json file in conjunction with setting the "workspaces" key.

This may only be an issue when using yarn but worth mentioning. Not blocking, but rather an annoyance of seeing many many warnings.

6utt3rfly commented 2 years ago

Thanks for reporting @rathpc ! I'm seeing conflicting opinions on what to do about it... some think yarn should be updated, but I see that react-redux removed workspaces from their package.json file.

jsep is built with pnpm which has a separate pnpm-workspace.yaml so the workspaces in package.json can probably be removed. jsep definitely doesn't want to change the private flag though, unless it was moved into the packages folder.

@EricSmekens - any issues with removing the workspaces key from package.json?