EricSmekens / jsep

JavaScript Expression Parser
http://ericsmekens.github.io/jsep/
MIT License
840 stars 136 forks source link

Add "types" to package.json "exports" #230

Closed abstractmatter closed 2 years ago

abstractmatter commented 2 years ago

The "exports" property has precedence over "typings", thus Typescript 4.7+ doesn't recognise the types.

Adding "types" in "exports" solve the issue.

6utt3rfly commented 2 years ago

Thank you for the PR @abstractmatter ! It looks fine to me, except that I read in the typescript blog that types is supposed to be the first entry though (instead of last in this PR)?

Could you also please update your commit message to follow the contributing conventions (i.e. fix: add types to package.json exports)

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 1.3.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version @jsep-plugin/arrow-v1.0.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version @jsep-plugin/assignment-v1.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version @jsep-plugin/async-await-v1.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version @jsep-plugin/comment-v1.0.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version @jsep-plugin/new-v1.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version @jsep-plugin/numbers-v1.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version @jsep-plugin/object-v1.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version @jsep-plugin/regex-v1.0.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version @jsep-plugin/spread-v1.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version @jsep-plugin/template-v1.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version @jsep-plugin/ternary-v1.1.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: