EricTRocks / pyflowgraph

Python Module for displaying flowgraphs using Pyside or PyQt.
BSD 3-Clause "New" or "Revised" License
76 stars 29 forks source link

python2/3 compatibility, PySide/PySide2 PyQt4/PyQt5 compatibility, unicode_literals, setup.py #5

Closed willjp closed 7 years ago

willjp commented 8 years ago

Changes:

2x New Dependencies:

from .module import func

filter() to list-comprehension

I replaced your use of filter() with list-comprehensions. In python2 filter() returned a list, in python3 it returns an iterable. The output was being treated as lists in the code, so I kept them that way.

QApplication reused in tests if Maya, IPython, etc...

Minimal setup.py

drogenlied commented 8 years ago

Python2 sort of works now and I found a few problems while testing:

Python3 works correctly so far and I can't test PySide2 on either version right now.

phtaylor commented 7 years ago

Awesome. Thanks a lot!

phtaylor commented 7 years ago

Oops, I think I'll need to revert this merge in favor of the other branch. I'll fix it.

phtaylor commented 7 years ago

This merge has now been reverted.