EricZimmerman / evtx

C# based evtx parser with lots of extras
MIT License
282 stars 59 forks source link

Create Security_Microsoft-Windows-Security-Auditing_4728.map #165

Closed CluelessAtCoding closed 3 years ago

CluelessAtCoding commented 3 years ago

Create Map for Event ID 4728

Description

Create New Map for Event ID 4728

Checklist:

Please replace every instance of [ ] with [X]

Thank you for your submission and for contributing to the DFIR community!

AndrewRathbun commented 3 years ago

Looks great, thanks for following the template! Just be sure next time to remove trailing spaces and add the newline!

 Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:62:104: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:63:26: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:64:23: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:65:19: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:66:21: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:67:21: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:68:42: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:69:60: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:70:43: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:71:18: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:72:48: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:73:30: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:74:40: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:75:15: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:78:87: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:79:80: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:80:48: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:81:48: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:82:80: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:83:85: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:84:50: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:85:49: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:86:47: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:87:39: [error] trailing spaces (trailing-spaces)
CluelessAtCoding commented 3 years ago

Looks great, thanks for following the template! Just be sure next time to remove trailing spaces and add the newline!

 Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:62:104: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:63:26: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:64:23: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:65:19: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:66:21: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:67:21: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:68:42: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:69:60: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:70:43: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:71:18: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:72:48: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:73:30: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:74:40: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:75:15: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:78:87: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:79:80: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:80:48: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:81:48: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:82:80: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:83:85: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:84:50: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:85:49: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:86:47: [error] trailing spaces (trailing-spaces)
Error: Maps/Security_Microsoft-Windows-Security-Auditing_4728.map:87:39: [error] trailing spaces (trailing-spaces)

Apologies, I will do better next time :)

AndrewRathbun commented 3 years ago

You did fine! Minor things but the rest looked awesome. Thanks for your contribution 👍