EricaSkerrett / bme590final

Final project (image processing)
GNU General Public License v3.0
0 stars 1 forks source link

Write unit tests for image_encoder and view_b64_image #23

Closed sputney13 closed 5 years ago

sputney13 commented 5 years ago

currently passing via assert 1 == 1

EricaSkerrett commented 5 years ago

@suyashkumar @mlp6 Hi! To unit test the encoders, I'm currently working on uploading a test_images folder to git. The unit test would then open an image from this folder to run through the code. However, checking the output of this requires super long strings...Would you recommend testing with really compressed image files, spending time looking into generating an image file within the unit test itself, or another option? Thank you!

mlp6 commented 5 years ago

Can you just check the first few and last few characters in the encoded data?

EricaSkerrett commented 5 years ago

Yep! Makes sense. I guess that + the length should be pretty foolproof.

EricaSkerrett commented 5 years ago

Do you think there would be a problem with including the test_images folder?

mlp6 commented 5 years ago

Nope, as long as it is small.