search

ErichDonGubler / moz-webgpu-cts

An extremely fast (but opinionated) tool for working with WPT metadata while developing an implementation of WebGPU in a web browser.
Apache License 2.0
0 stars 2 forks source link

Rework `TestScope` model to meet Servo's needs #103

Closed ErichDonGubler closed 1 month ago

ErichDonGubler commented 2 months ago

In #92, I had suggested a new representation for TestScope where Browser and TestVisibility were two dimensions on which other products could integrate with moz-webgpu-cts. However, that model is wrong; Servo only really has one set of paths and runner URLs that it cares about, currently. One can observe this with the todo!()s that I merged in that PR. 😅 So, I'm fixing my mistake!

Throw away TestVisibility and make TestScope mirror Browser variants with additional, independent structure per-browser. Concretely, make TestScope use either a FirefoxTestScope or a ServoTestScope, the latter of which only has a WebGpu variant (for now).

ErichDonGubler commented 1 month ago

@sagudev, I'm hoping to at least get confirmation that d04e532c02cf13744de69183bcce05973f752dd2 actually fulfills the premise of this PR. If you want to give me a fuller review, then great (!), but I don't expect it. 🙂

ErichDonGubler commented 1 month ago

@sagudev: Ah, you'd commented on the commit, but not this PR. I'll migrate that over here, and get it resolved.