search

ErichDonGubler / termion

A bindless library for controlling terminals/TTY.
MIT License
4 stars 1 forks source link

Merge 'master' branch of 'redox-os/termion' into 'windows' branch #14

Closed agavrilov closed 5 years ago

agavrilov commented 5 years ago

Our company is using termion on Linux and macOS to create command-line utilies. Now we are interested in Windows port of these utilies. I'll try to push your Windows of termion as much as I can if you don't mind

ErichDonGubler commented 5 years ago

This is currently failing CI -- could we please get the Linux/MacOS builds working before this gets merged? I'm assuming upstream is green, but I'm on mobile right now and can't easily check.

ErichDonGubler commented 5 years ago

Also, welcome! Thanks for taking the time to make a PR! I don't consider myself the exclusive owner of these Windows changes, so if you wanted to fork upstream and run with them you'll have no complaints from me. :)

agavrilov commented 5 years ago

I have added Windows test environment for Travis. It uses MSYS as a shell and Windows tests are failing on it. I commented out these failing Windows tests until I have time to fix them

ErichDonGubler commented 5 years ago

Awesome! Thank you. :) Merging!

Just so you know: my wife had a baby two days ago right about when you submitted this PR...if it weren't for that, I definitely would have merged this earlier!

agavrilov commented 5 years ago

Congratulations on a new baby!