search

ErickTamayo / laravel-scout-elastic

Elastic Driver for Laravel Scout
MIT License
916 stars 242 forks source link

Fix sort results #135

Closed CasperLaiTW closed 4 years ago

CasperLaiTW commented 5 years ago

Elasticsearch sort results are correctly, but after call $model-> getScoutModelsByIds method, laravel/scout will newQuery without order value in query.

same problem in Laravel Scout Algolia engine, and they was fixed.

https://github.com/laravel/scout/commit/dafbfa74031c660f34f93a64b566e6164f9e5baa#diff-f2faa85f27580a9b67d73a8a273bfef1

ErickTamayo commented 4 years ago

Thanks, @CasperLaiTW. I want to merge your PR but 8.0 just changed the Engine location and namespace.

If you want, you can solve the conflicts, or I can do it myself, but I don't want you to not be added as a contributor.

Let me know what you think.

CasperLaiTW commented 4 years ago

Thanks, @CasperLaiTW. I want to merge your PR but 8.0 just changed the Engine location and namespace.

If you want, you can solve the conflicts, or I can do it myself, but I don't want you to not be added as a contributor.

Let me know what you think.

I will solve the conflicts! will push soon

CasperLaiTW commented 4 years ago

@ErickTamayo I closed this PR, I think big changes with new version, commit mess up. Please check #142