search

Ericsson / CodeCheckerEclipsePlugin

This is an Eclipse plugin that shows C/C++ static analysis results found by Clang Static Analyzer and Clang Tidy
Eclipse Public License 1.0
32 stars 13 forks source link

Fixed pathSeparator misuse #148

Closed vodorok closed 5 years ago

vodorok commented 5 years ago

The File.pathSeparator returns ":" but File.separator was needed "/". Path separator was misused in the log file resolution, and in the project environment setting. Caused that only previously added projects behaved correctly, new ones wouldn't have gotten analyzed.

vodorok commented 5 years ago

@gyorb Should I fix #147 issue in this pull request also?

gyorb commented 5 years ago

@Vodorok you can create a separate PR for the fix of #147

vodorok commented 5 years ago

@gyorb Thanks for the hit. Fixed and changed comment to better reference the java docs.

vodorok commented 5 years ago

Should be merged after #145.

gyorb commented 5 years ago

Please resolve the conflicts, otherwise LGTM.

vodorok commented 5 years ago

I'm afraid, the majority of the contents of this pr, went in with #145. Used the File.separator fixes, for testing, and accidentally left those in. How should we resolve this? Modify the Commit description mentioning the related changes in: a204eae? See diff: https://github.com/Ericsson/CodeCheckerEclipsePlugin/commit/a204eae54e7990c2d70b34bf44eb8aff74d0f9cb#diff-46d22959add1c4f814329643b65e9e98

gyorb commented 5 years ago

@Vodorok we can close this. For the comment fix please create a separate PR.