Closed dkrupp closed 8 years ago
maybe dif fileinfoaction is not needed as the filepath is in the checkedFile field of the reportData record in thrift.
So maybe fiaResult and fiaBug object can be removed.
FileInfoAction fiaResult = new FileInfoAction(new FileInfoRequest(action.getRequest() .getServer(), rd.getFileId())); fiaResult = innerRunner.requireResult(fiaResult); if (fiaResult.getStatus() != ActionStatus.SUCCEEDED) { throw new RuntimeException("Bad status for inner action: " + fiaResult); } FileInfoAction fiaBug = new FileInfoAction(new FileInfoRequest(action.getRequest() .getServer(), rd.getLastBugPosition().getFileId())); fiaBug = innerRunner.requireResult(fiaBug); if (fiaBug.getStatus() != ActionStatus.SUCCEEDED) { throw new RuntimeException("Bad status for inner action: " + fiaBug); } BugPathItem lastBugItem = new BugPathItem(new BugPathItem.Position(rd .getLastBugPosition().getStartLine(), rd.getLastBugPosition().getStartCol()), new BugPathItem.Position(rd.getLastBugPosition().getEndLine(), rd .getLastBugPosition().getEndCol()), rd.getLastBugPosition().getMsg(), fiaBug.getResult().get().getFilePath());
maybe dif fileinfoaction is not needed as the filepath is in the checkedFile field of the reportData record in thrift.
So maybe fiaResult and fiaBug object can be removed.