search

Ericsson / CodeCompass

CodeCompass is a software comprehension tool for large scale software written in C/C++ and Java
https://codecompass.net
GNU General Public License v3.0
520 stars 102 forks source link

Fix recursive caller nodes #569

Closed andocz closed 1 year ago

andocz commented 2 years ago

Fixes #544, which was caused by the children of the child caller nodes being set incorrectly. Recursions in the tree are also avoided now.

There is one issue remaining that I need some feedback on. When the child caller nodes are created, the reference count after their name is appended to instead of replaced, which means reference counts keep piling up as we go deeper in the tree. See "Caller(4)(8)(1)" in this screenshot. This is not intentional, is it? In that case I can fix it too.

mcserep commented 2 years ago

Great work finding the source of this issue!

There is one issue remaining that I need some feedback on. When the child caller nodes are created, the reference count after their name is appended to instead of replaced, which means reference counts keep piling up as we go deeper in the tree. See "Caller(4)(8)(1)" in this screenshot.

No, it's not a feature, but a bug 😄