Ericsson / CodeCompass

CodeCompass is a software comprehension tool for large scale software written in C/C++ and Java
https://codecompass.net
GNU General Public License v3.0
520 stars 102 forks source link

Upgrade NodeJS and NPM for tarball build #624

Closed mcserep closed 1 year ago

mcserep commented 1 year ago

The new web GUI officially requires NodeJS v18+, while in the Ubuntu 16.04 based tarball build script we have NodeJS 14 installed, which fails.

Unfortunately NodeJS v18 is not compatible with Ubuntu 16.04. (GLIBC mismatch error.) This PR upgrade NodeJS from v14 to v16 and NPM from v6 to v8 in tarball CI build script and hopefully this will be enough.

@mdeme01 Do we really need NodeJS v18 for the new frontend to build, or was it specified simply as the current LTS version?

@intjftw, @zporky Do we still need these legacy tarball builds in Ericsson?

mdeme01 commented 1 year ago

@mdeme01 Do we really need NodeJS v18 for the new frontend to build, or was it specified simply as the current LTS version?

I tested it and I didn't have any problems installing packages and building the application with Node v16, so it should be fine. I've only written v18 because it was the current LTS version at the time.

mcserep commented 1 year ago

I tested it and I didn't have any problems installing packages and building the application with Node v16, so it should be fine. I've only written v18 because it was the current LTS version at the time.

@mdeme01 Thanks for the quick response, I think we shall keep Node v18 in the documentation as a requirement, as the end of support for v16 is coming soon. But hopefully we can make this tarball build with it to support legacy operating systems in Ericsson.

Let's see whether pipeline succeeds :smile: