search

Ericsson / CodeCompass

CodeCompass is a software comprehension tool for large scale software written in C/C++ and Java
https://codecompass.net
GNU General Public License v3.0
497 stars 96 forks source link

Incremental parsing issue fixes #736

Closed dbukki closed 1 month ago

dbukki commented 2 months ago

Fixes #735

In accordance with the diagnosis outlined in https://github.com/Ericsson/CodeCompass/issues/735#issuecomment-2078918431 , the following fixes have been made:

  1. A new CppAstNodeMetricsFileView db view has been added to manage the AST node ID <-> File ID association (_astNodeIdCache) in CppMetricsParser::CppMetricsParser.
  2. The .size() call in SourceManager::removeFile has been replaced by a new isSingletonResult helper function in dbutil.
mcserep commented 1 month ago

Looks good to me! I had to resolve a merge conflict, so now my approval is not enough as the last commiter.

@intjftw Please approve it as well (review it too of course, if you would like 😄 )!