Refactor executor to pass shell arguments as array

Ericsson / CodecheckerVSCodePlugin

VSCode plugin that shows bugs detected by the Clang Static Analyzer and Clang Tidy analyzers using CodeChecker as a backend.

Apache License 2.0

24 stars 7 forks source link

Refactor executor to pass shell arguments as array #57

Closed Discookie closed 2 years ago

Discookie commented 2 years ago

Closes #56.

Previously, we .join(' ')-ed the executor arguments. With this refactor, the executor no longer constructs the full command-line, but rather directly passes the args array to child_process.spawn.

For the user-facing input (arguments setting) and output (command-line preview), the shell-quote package is used.

csordasmarton commented 2 years ago

@Discookie can you please rebase your branch. It contains some merge conflict. I would like to try it out and merge it if I don't find any problem.