search

Ericsson / clang

Cross Translation Unit analysis capability for Clang Static Analyzer. (Fork of official clang at http://llvm.org/git/clang)
http://clang.llvm.org/
Other
15 stars 10 forks source link

Added macro expansions to the plist output #474

Closed Szelethus closed 5 years ago

Szelethus commented 6 years ago

This is an experimental implementation for displaying macro expansion in the plist output. This is little more than a copy-paste from HTMLRewrite.cpp, which re-lexes and preprocesses the entire file. While this definitely should be regarded as a huge hack and only a temporary solution, it should be stable enough for testing.

dkrupp commented 6 years ago

Can one of the admins verify this patch?

martong commented 6 years ago

run tests

martong commented 6 years ago

run tests looks like tmux analysis hangs, this may be because of a restart of jenkins, so just restarted the test

martong commented 6 years ago

Seems like the CTU analysis is slowed down terribly by this patch :( Even though for the first sight it seems an independent change. Could you please have a look? I can help you if you got stuck. http://ci1.codechecker.gic.ericsson.se:8080/job/ctu_pipeline_pullrequest/37 The main branch (ctu-clang6) currently runs quite fast even on the whole pipeline, not just on the PR pipeline: http://ci1.codechecker.gic.ericsson.se:8080/job/ctu_pipeline/

martong commented 6 years ago

Looks like this is not a clang problem, but rather a problem with csa_testbench which tries to parse the plists (I guess). the python process got stuck and uses 100% CPU:

clang-j+  6568  6551 95 Aug21 ?        13:49:44 python /var/jenkins_home/ctu_pipeline_aux/csa-testbench/run_experiments.py --config /var/jenkins_home/mustpass_projects_jenkins.json --jobs 8 --fail_on_assert
Szelethus commented 5 years ago

I completely reinvented this and posted it on Phabricator: https://reviews.llvm.org/D52742. Looking at the implementation though, it should be compatible with earlier clang versions.