search

Ericsson / clang

Cross Translation Unit analysis capability for Clang Static Analyzer. (Fork of official clang at http://llvm.org/git/clang)
http://clang.llvm.org/
Other
15 stars 10 forks source link

Use SmallSetVector in ASTImporter specific lookup #539

Closed martong closed 5 years ago

martong commented 5 years ago

The difference between SetVector and other sets is that the order of iteration is guaranteed to match the order of insertion into the SetVector. This property is really important for things like sets of pointers. Because pointer values are non-deterministic (e.g. vary across runs of the program on different machines), iterating over the pointers in the set will not be in a well-defined order.

martong commented 5 years ago

I think this should fix #525 @balazske Could you please check?

gamesh411 commented 5 years ago

This seems to be a good change, even if the current problem at hand is not fixed by it.

martong commented 5 years ago

https://reviews.llvm.org/D53708