search

Ericsson / clang

Cross Translation Unit analysis capability for Clang Static Analyzer. (Fork of official clang at http://llvm.org/git/clang)
http://clang.llvm.org/
Other
15 stars 10 forks source link

Handle type-aliased friend declarations in ASTImporterLookupTable #583

Closed gamesh411 closed 5 years ago

gamesh411 commented 5 years ago

There were numerous asserts thanks to type aliased friend declarations, which were not handled in the ASTImporterLookupTable visitor. This patch adds a test case which crashed before, but this implementation fixes the crash. The semantic reasoning for the implementation is summarized in the comments near the change.

fixes #581

gamesh411 commented 5 years ago

Thanks for pointing out the unsused var in the test case :)

martong commented 5 years ago

ping

balazske commented 5 years ago

I see "@gamesh411 gamesh411 requested review from martong and balazske 4 days ago" but I can not approve it, there is no button for review.

martong commented 5 years ago

In this case we have to add the reviews again by clicking on them, just did it.