Codecov Report

Merging #188 (0655a46) into master (1ca6687) will increase coverage by 0.09%. The diff coverage is 36.89%.

@@             Coverage Diff              @@
##             master     #188      +/-   ##
============================================
+ Coverage     76.70%   76.80%   +0.09%     
+ Complexity      712      711       -1     
============================================
  Files            77       77              
  Lines          2194     2194              
  Branches        163      160       -3     
============================================
+ Hits           1683     1685       +2     
+ Misses          484      482       -2     
  Partials         27       27

Flag	Coverage Δ
unit-tests	`76.80% <36.89%> (+0.09%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../bss/cassandra/ecaudit/auth/AuditAuthKeyspace.java	`0.00% <0.00%> (ø)`
...bss/cassandra/ecaudit/auth/AuditAuthenticator.java	`95.23% <ø> (ø)`
...n/bss/cassandra/ecaudit/auth/AuditRoleManager.java	`85.93% <0.00%> (-1.37%)`	:arrow_down:
...bss/cassandra/ecaudit/auth/ConnectionResource.java	`86.20% <ø> (ø)`
...caudit/entry/factory/AuditEntryBuilderFactory.java	`5.71% <0.00%> (+0.02%)`	:arrow_up:
...caudit/entry/factory/StatementResourceAdapter.java	`2.56% <0.00%> (+0.43%)`	:arrow_up:
...ndra/ecaudit/entry/suppressor/SuppressRegular.java	`80.00% <0.00%> (ø)`
...ssandra/ecaudit/flavor/CassandraFlavorAdapter.java	`0.00% <0.00%> (ø)`
...bss/cassandra/ecaudit/logger/Slf4jAuditLogger.java	`94.28% <ø> (ø)`
...ss/cassandra/ecaudit/auth/WhitelistDataAccess.java	`14.41% <14.28%> (ø)`
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ca6687...0655a46. Read the comment docs.

eperott commented 2 years ago

On a general note - I believe there should be a fair bit of documentation to update as well in this patch.

eperott commented 2 years ago

Did you explore if it would make sense to make ecAudit more of a plug-in for the audit-feature of Cassandra 4.0? Not entirely sure if it makes sense or if it would allow us to still provide all the ecAudit-specific features. But perhaps worth considering?

Ericsson / ecaudit

Support Cassandra 4.0 #188

Codecov Report