ioolkos
commented
4 days ago I have a quick question on line: https://github.com/Ericsson/ered/blob/4374c5e2684dba9cf462a67b4fae4a8415099d33/src/ered_client.erl#L236
is it by design that sth like ({auth, Auth = none}, S) -> S#opts{auth = Auth}; is missing here?
At least in connect {auth, none} seems to be allowed.
I built a little plugin using ered as an application as in this PR. Works great so far! :)
This PR contains some separate commits. It might be better to review them one by one.
Merge ered and ered_cluster processes
The command handling code is moved from ered to ered_cluster. The ered module becomes just an API module without a process of its own. This eliminates some duplicated structures and copying between processes.
Change ered_client_sup into to simple_one_for_one supervisor.
App and supervision tree
Ered becomes an application with its own supervision tree.
In the API, connect_cluster/2 replaces start_link/2 and close/1 replaces stop/1. The processes are added to ered's own supervision tree. An ered instance monitors the caller and closes down if the owner dies, much like the controlling process concept in gen_tcp and ssl.
Add info message 'cluster_stopped' sent in ered_cluster:terminate/1
The process traps exits so terminate/1 will run even if the process crashes.
Unify info messages from ered_client and ered_cluster
Make the messages sent by a standalone ered_client match those sent by a cluster client for each client, i.e. a map with the keys msg_type, reason, client_id, addr and the optional fields cluster_id and master.