Ericsson / ered

An Erlang client library for Valkey/Redis Cluster
MIT License
11 stars 6 forks source link

Run tests in CI #5

Closed bjosv closed 2 years ago

bjosv commented 2 years ago

Initial and simple steps to compile and run tests in CI.

bjosv commented 2 years ago

Current state is that eunit requires a single running redis, and common tests requires redis-cli. Common tests will start a cluster by using containers from within the tests, but use redis-cli to trigger manual failover and many other scenarios.

bjosv commented 2 years ago

So the common-tests depend on docker and might download a Redis image on the fly when running the tests?

Yes, unless already existing, it downloads all containers layers needed. Currently it does not specify which version, which means latest, which currently is Redis 7.0.1. I guess we would like to change this to be able to test redis compatibility.

zuiderkwast commented 2 years ago

I'm skeptical to downloading stuff as part of running the tests. It's better if it's downloaded in another command such as rebar3 as test get-deps (which would work if this would be erlang deps for the tests).