Closed ghost closed 9 years ago
Well, that "somewhere.com" only shows up in three places. It's probably coming from [this one]():
4862 var tmpEmailAddress = attendee.id.replace(/^mailto:/, '');
4863 if (tmpEmailAddress.indexOf("@") > 0) {
4864 mailbox.addChildTag("EmailAddress", "nsTypes", tmpEmailAddress);
4865 }
4866 else {
4867 mailbox.addChildTag("EmailAddress", "nsTypes", "unknown@somewhere.com");
4868 }
Looks like an empty mailto: link or email address with no @ sign returns your mystery participant. I'd start by looking for an invitee whose address is missing from the email.
At the moment, I can't reproduce it anymore; closed for now.
I have a reproducible situation:
Create a new item in calendar 'Leave MB':
After selecting the participants (only 1), the overview shows:
After finishing (saving) the event and reopening it, it shows as:
As you can see, a new participant is added mysteriously.
The headers of the sent invitation:
From: Minddev <minddev@mydomain.nl>
To: "unknown@somewhere.com" <unknown@somewhere.com>, "Doe, John"
<john.doe@mydomain.nl>
Subject: Test 2
Thread-Topic: Test 2
Thread-Index: AdBse9zVzTtbiWOYRCycMbSDFW0nDg==
Date: Wed, 1 Apr 2015 13:00:43 +0000
Message-ID:
<BD318A009997BE4C9B61D838A9B2D4C612DA6A4D@ORANGEII.mydomain.local>
Content-Language: en-US
Can I help with debugging?
Send us your logs >> github mail address :
please add this code dump("\nattendeeId 1001 : "+attendee.id);
to file {plugin}/chrome/content/mivExchangeCalendar.js , lineNo: 4861
let me know what is the output..
this is specific to your email address :)
Thanks
I've added the dump to the first file from this list
-./wo6ji4b0.default/extensions/exchangecalendar@extensions.1st-setup.nl/interfaces/exchangeCalendar/mivExchangeCalendar.js:4867: mailbox.addChildTag("EmailAddress", "nsTypes", "unknown@somewhere.com");
-./wo6ji4b0.default/extensions/exchangecalendar@extensions.1st-setup.nl/interfaces/exchangeEvent/mivExchangeEvent.js:536: mailbox.addChildTag("EmailAddress", "t", "unknown@somewhere.com");
This was dumped:
attendeeId 1001 : Doe
tmpEmailAddress : Doe
attendeeId 1001 : mailto:john.doe@mydomain.nl
tmpEmailAddress : john.doe@mydomain.nl
I also dumped the contents of tmpEmailAddress.
Looking at this, I think I know why it breaks. This is the full string for the recipient:
Doe, John <john.doe@mydomain.nl>
As you can see, there is a comma in it. Could it be, the extension needs to be adjusted to support recipients with a comma in the name?
Can you please so a little research on that. Prefer to check In outlook :)
-----Original Message----- From: "evamindbench" notifications@github.com Sent: 07/04/2015 14:29 To: "Ericsson/exchangecalendar" exchangecalendar@noreply.github.com Cc: "bavincen" bavincen.in@gmail.com Subject: Re: [exchangecalendar] Meeting has participant unknown@somewhere.com(#136)
I've added the dump to the first file from this list -./wo6ji4b0.default/extensions/exchangecalendar@extensions.1st-setup.nl/interfaces/exchangeCalendar/mivExchangeCalendar.js:4867: mailbox.addChildTag("EmailAddress", "nsTypes", "unknown@somewhere.com"); -./wo6ji4b0.default/extensions/exchangecalendar@extensions.1st-setup.nl/interfaces/exchangeEvent/mivExchangeEvent.js:536: mailbox.addChildTag("EmailAddress", "t", "unknown@somewhere.com");This was dumped: attendeeId 1001 : Doe tmpEmailAddress : Doe attendeeId 1001 : mailto:john.doe@mydomain.nl tmpEmailAddress : john.doe@mydomain.nl I also dumped the contents of tmpEmailAddress. Looking at this, I think where it breaks. This is the full string for the recepient: Doe, John john.doe@mydomain.nl As you can see, there is a comma in it. Could it be, the extension needs to be adjusted to support recipients with a comma in the name? — Reply to this email directly or view it on GitHub.
I changed my name on the Exchange server to:
John Doe <john.doe@mydomain.nl>
Now, the unknown address isn't added. The dump:
attendeeId 1001 : mailto:john.doe@mydomain.nl
tmpEmailAddress : john.doe@mydomain.nl
So the issue is resolved :)
-----Original Message----- From: "evamindbench" notifications@github.com Sent: 07/04/2015 18:15 To: "Ericsson/exchangecalendar" exchangecalendar@noreply.github.com Cc: "bavincen" bavincen.in@gmail.com Subject: Re: [exchangecalendar] Meeting has participant unknown@somewhere.com(#136)
I changed my name on the Exchange server to: John Doe john.doe@mydomain.nl Now, the unknown address isn't added. The dump: attendeeId 1001 : mailto:john.doe@mydomain.nl tmpEmailAddress : john.doe@mydomain.nl — Reply to this email directly or view it on GitHub.
Lol, that's not really a solution ;), only a workaround.
I think so 😉
-----Original Message----- From: "evamindbench" notifications@github.com Sent: 07/04/2015 18:35 To: "Ericsson/exchangecalendar" exchangecalendar@noreply.github.com Cc: "bavincen" bavincen.in@gmail.com Subject: Re: [exchangecalendar] Meeting has participant unknown@somewhere.com(#136)
Lol, that's not really a solution ;), only a workaround. — Reply to this email directly or view it on GitHub.
NB You don't need to have exchange to reproduce this; just follow these steps:
Doe, John <john.doe@example.com>
Now you'll see the unknown@somewhere.com address added. Also, the John Doe participant is now changed to: John <john.doe@example.com>
Great thanks. nice info.
-----Original Message----- From: "evamindbench" notifications@github.com Sent: 07/04/2015 18:49 To: "Ericsson/exchangecalendar" exchangecalendar@noreply.github.com Cc: "bavincen" bavincen.in@gmail.com Subject: Re: [exchangecalendar] Meeting has participant unknown@somewhere.com(#136)
NB You don't need to have exchange to reproduce this; just follow these steps: Open the calendar. Add a new event. Add the following participant: Doe, John john.doe@example.com Save the event. Open the new event. Now you'll see the unknown@somewhere.com address added. Also, the John Doe participant is now changed to: John john.doe@example.com — Reply to this email directly or view it on GitHub.
Hi Before fixing, Could you please confirm how does comma , taken place there. or are you just adding it..
All users in my Exchange address book have this format:
Display of name:
last name, first name
Email:
firstname.lastname@mydomain.nl
In the calendar, when I start typing the name of a participant, a drop down appears with the entries like this:
Last name, first name <firstname.lastname@mydomain.nl>
eg.
Doe, John <john.doe@example.com>
I just select the item from the dropdown and it is added to the participants as is.
@bavincen , as you've closed this ticket, does it mean it's fixed ?
I am having the same issue with the version 3.3.2
to be fixed in stable version. Thanks
Still seeing this issue with 3.4.0~beta4 @bavincen Can you please re-open the issue until it is fixed ? This is a potential leak of information, somewhere.com is an existing domain, it's a really bad idea to use valid domains as a fallback.
I agree, better to leave that participant, show an error or something.
For this specific case please also fix participants with a comma in the name, which is valid for that field.
Any progress on this? I did manually edit this out myself, but then updated to the new release and it overwrote my amendments.
I only found out when my boss freaked out over my including unknown@somewhere.com on an invite to a customer meeting.
p.s. as a temp fix, just change it for null@null
Its much better then having it go to an actual domain. As @Ruleke mentions, this is a serious security flaw at the moment.
If the domain owner of somewhere.com sets up a mail server, they will be getting all sorts of users calender invites.
I don't mind doing this, but I have no idea which branch to push to?
Hi You can send us a pull request thanks
We are planning to fix it in coming stable release
Sure thing
Ok sorry fro disappointing this issue is existing even when our addon is not installed. i am marking it invalid. please raise a concern in lightning community.. thanks
@bavincen ,to do that, it's a good thing to have a history of your debugging. Could you provide that here, then I'll create a proper bug report over there.
add a ics calendar type attendee name like
"firstname , lastname <email@domain.com>"
click ok
then click on the invitees list before closing you will see two attendeees
The bug is still there, as the unknown@somewhere.com is still in the code.
I made a pull request as this is a security risk...
https://github.com/Ericsson/exchangecalendar/pull/293
This changes unknown@somewhere.com to null@null
unknown@somewhere.com results in a delivery failure, as does null@null, but null@null is much safer as unknown@somewhere.com could result in information leak should they set up an email server.
Lightning has already fixed this issue.. please check it in Lighning 4.0 EWS beta7 TB 38*
Whenever I create a meeting to which I add participants, the following failure mail is sent do me:
The headers are also in it:
Headers:
Where does that unknown@somewhere.com participant come from? That's the literal address for it. Only the ones with thedomain are changed by me.
NB I'm using Exchange EWS Provider 3.3.1 on Thunderbird 31.5.0 and Lightning 3.3.3.