search

Ericsson / exchangecalendar

Exchange 2007/2010/2013 Calendar, Tasks, Contacts and GAL Provider.
GNU General Public License v3.0
925 stars 112 forks source link

Fix: The shared folder/folder id can also be a task list #461

Open Pro opened 8 years ago

Pro commented 8 years ago

If another user shares a task list with you, then you can add the task list through the Folder ID. Therefore the folderClass can also be an IPF.Task

The rest of the plugin still works since calendar and tasks are the same.

bavincen commented 8 years ago

ahh ok! https://msdn.microsoft.com/en-us/library/bb176446%28v=office.12%29.aspx Appointment class is Calendar item cant be a task

Pro commented 8 years ago

@bavincen sorry I don't understand your comment... Can you clarify that? Any reason why you didn't merge the commit?

bavincen commented 8 years ago

please give me some details what you commit will do. changing one line will provide that feature?

Pro commented 8 years ago

Ok, I'll try my best: Your EWS plugin allows to add shared folders by indicating the EWS ID of that folder. E.g. another user can share his calendar with me. To add the calendar to Thunderbird I use the ID of the folder to add it.

The same can happen with a task list: If another user shares a task list with me, I could take the EWS ID and add it to the tasks list in Thunderbird. At this point your EWS plugin fails. The folder class is IPF.Task and thus it fails with alert(this.globalFunctions.getString("calExchangeCalendar", "ecErrorServerAndMailboxCheck", [aMsg, aCode], "exchangecalendar")); (This error message will never be shown by the way, the plugin just hangs and does nothing). With my change the shared task list is accepted. And since a Task List is handled exactly the same as Appointments, everything else works. I tested this on my Thunderbird installation and it works flawlessly. There is no need to change any other line of code.

Pro commented 8 years ago

@bavincen any updates?