search

EricssonResearch / bowser

A WebRTC browser for iOS developed in the open
BSD 2-Clause "Simplified" License
208 stars 65 forks source link

Move to WKWebView #61

Closed stefanalund closed 8 years ago

stefanalund commented 8 years ago

Now reloads and navigation does not interfere with WebRTC support (injection), making the app much faster and more reliable.

Requires iOS 9.0.

stefanalund commented 8 years ago

Closes https://github.com/EricssonResearch/bowser/issues/1.

truestep commented 8 years ago

Cool. Is this change in appstore already?

stefanalund commented 8 years ago

Nope, not yet. We want to test it more and merge it before posting a new version. Let us know if it works for you! Also, we are going to make a new release of OpenWebRTC that, among other things, fixes Bowser crashes on 32-bit devices.

stefanalund commented 8 years ago

@stefhak had any chance to look at this?

bamboolsu commented 8 years ago

Maybe we can fix these issues of #359, #504 and #510 when we release new version.

stefanalund commented 8 years ago

@bamboolsu yes, but I would not like to wait too long before publishing a new version of Bowser. I would rather make incremental updates once we fix different issues. Have you verified that this version of Bowser works as well/bad as the previous one (without WKWebView)?

stefanalund commented 8 years ago

@superdump @stefhak OK to land this?

stefhak commented 8 years ago

I have not the competence to test, but from my perspective, given what I can judge, we should merge. My only question would be if the version of owr you build on has the string '"profileLevelId": "42e01f",' in webrtc.js; if so I'd remove it as it negotiates h264 with FF, but things seem to be very unstable.

superdump commented 8 years ago

:+1: It's nice that so much code can be removed. As long as it's tested against OWR, Chrome and Firefox, go ahead and merge it.

stefanalund commented 8 years ago

The remaining question for me is whether we should make a new pod release first. I have been testing with my own build of a more recent OpenWebRTC.