libffi: set FFI_MMAP_EXEC_WRIT and unset FFI_MMAP_EXEC_SELINUX on Android

EricssonResearch / cerbero

OpenWebRTC cerbero fork

GNU Lesser General Public License v2.1

19 stars 58 forks source link

libffi: set FFI_MMAP_EXEC_WRIT and unset FFI_MMAP_EXEC_SELINUX on Android #15

Closed Rugvip closed 9 years ago

Rugvip commented 9 years ago

This fixes a crash on Android Found here: https://github.com/frida/frida/blob/d3679e46df36986beca03da59be7acd691b6babe/releng/config.site.in#L119 (thanks to @oleavr)

sdroege commented 9 years ago

Makes sense but do you have some more details about the crash? On which versions of Android does it happen, in which situations?

sdroege commented 9 years ago

And did someone report it to libffi?

Rugvip commented 9 years ago

This was the error: `signal 11 (SIGSEGV), code -6 (SI_TKILL), fault addr 0x9fa79b00`` Same as the error in EricssonResearch/openwebrtc#177, which is the one it fixes It happens when trying to call a closure created by libffi, on at least Lollipop and KitKat.

sdroege commented 9 years ago

In that ticket it's all about iOS. Do you have a backtrace for Android?

Rugvip commented 9 years ago

I don't, but it's identical to the seconds comment, segfault when calling the callback in g_task_return_now.

superdump commented 9 years ago

LGTM. @Rugvip can you report this upstream and merge this?