packages/base-system: add back libiconv on iOS

EricssonResearch / cerbero

OpenWebRTC cerbero fork

GNU Lesser General Public License v2.1

19 stars 58 forks source link

packages/base-system: add back libiconv on iOS #41

Closed alessandrod closed 8 years ago

alessandrod commented 8 years ago

I can see that the dependency has been added and then removed recently. Without it iOS compilation fails for me. Am I missing something?

superdump commented 8 years ago

Poke Matthew - it seems it was removed intentionally as its now included by the platform. Maybe it needs some platform SDK version checking to decide whether to add it or not.

sdroege commented 8 years ago

It's part of the platform, yes, and should just work without. How is something failing without building it ourselves?

superdump commented 8 years ago

cerbero doesn't fail. Building apps fails it seems. Can you try adding the system libiconv to the xcode project?

stefanalund commented 8 years ago

That solves the problem for me.

sdroege commented 8 years ago

Yes that's what should be done, see e.g. http://cgit.freedesktop.org/~slomo/gst-sdk-tutorials/commit/gst-sdk/tutorials/xcode%20iOS?id=77b2656d6d661f422c0ddd1b4357f829a0ef9e5d

superdump commented 8 years ago

Closing.