ercolorspace: Properly transform caps to only allow format combinations ...

EricssonResearch / openwebrtc-gst-plugins

OpenWebRTC specific GStreamer plugins

BSD 2-Clause "Simplified" License

51 stars 46 forks source link

ercolorspace: Properly transform caps to only allow format combinations ... #27

Closed sdroege closed 9 years ago

sdroege commented 9 years ago

...we can handle

https://github.com/EricssonResearch/openwebrtc-gst-plugins/issues/25

stefanalund commented 9 years ago

Getting closer :) The video on the other side (Chrome) is black and there is an error message that I will post later.

stefanalund commented 9 years ago

409:gst_inter_video_src_create:<source-1>[00m Failed to negotiate caps video/x-raw, format=(string)BGRA, width=(int)640, height=(int)480, pixel-aspect-ratio=(fraction)1/1, interlace-mode=(string)progressive, colorimetry=(string)sRGB, framerate=(fraction)30/1
==== Error message start ====
Error in element source-1.
Error: Internal data flow error.
Debugging info: gstbasesrc.c(2943): void gst_base_src_loop(GstPad *) (): /GstPipeline:transport-agent-1/GstBin:source-bin-1/GstInterVideoSrc:source-1:
streaming task paused, reason not-negotiated (-4)
==== Error message stop ====

superdump commented 9 years ago

As a note, that black and white checkerboard bug looks like an old bug in libvpx we had last year.

superdump commented 9 years ago

Maybe we need to check the cerbero libvpx build against our build scripts in case there's a workaround/fix that is needed. I seem to remember something about compiler optimisations.

sdroege commented 9 years ago

Ah, interesting. @nirbheek, can you check the cerbero libvpx build settings against the one from the build scripts?

stefanalund commented 9 years ago

These kind of video images are not always present. Most of the time I only get black frames.

superdump commented 9 years ago

Here it is: https://code.google.com/p/webm/issues/detail?id=603

nirbheek commented 9 years ago

I've pushed the change: https://github.com/nirbheek/cerbero/commit/86df1d951783aad7c83ff6cece1020cc6a712069

@sdroege Once we've tested that this fixes the issue, I think this can go to upstream Cerbero as well since it's not specific to OWRTC.

stefanalund commented 9 years ago

Still black frames after updating to latest Cerbero.

nirbheek commented 9 years ago

I need to see if the configure option was actually added; can you give me the contents of:

~/cerbero/logs/ios*/libvpx-configure.log ? We can continue this on IRC to avoid polluting this bug.

sdroege commented 9 years ago

The black frames have other reasons, there are multiple broken things currently :) libvpx part should just produce funny looking pictures