search

EricssonResearch / openwebrtc-gst-plugins

OpenWebRTC specific GStreamer plugins
BSD 2-Clause "Simplified" License
50 stars 46 forks source link

Build fixes #32

Closed nirbheek closed 9 years ago

nirbheek commented 9 years ago

Allows us to disable erdtls in Cerbero, and prefer using SDK version 20

sdroege commented 9 years ago

Why Android API level 19 or 20? Are we using anything that needs something newer than 9?

nirbheek commented 9 years ago

@sdroege I didn't check, but the latest Android SDK only ships API level 20, and owrtc-gst-plugins was using 19 already.

@superdump I defaulted it to yes to not break the build scripts, but now that master uses dtls, it makes sense to default to no.

Rugvip commented 9 years ago

@sdroege we might as well use the latest platform jar, it's not the same as minimum SDK version. Although the latest API level is 22, so I'm not sure why you only see android-20 @nirbheek

sdroege commented 9 years ago

Or maybe just have a loop there from 22 to 9 (or something) and takes the highest available SDK version? I only have 19 and 9 installed currently.

nirbheek commented 9 years ago

configure now loops over API from 22 to 9 (downwards) and selects the first one it finds.

nirbheek commented 9 years ago

I changed configure to loop up from 9 to 22, so we select the oldest API found. That ensures the binaries will work on old devices as well.

nirbheek commented 9 years ago

About using the oldest or newest API level:

<rugvip> actually, I realize that for now it doesn't really matter
<rugvip> since we only use ot for the video source anyway
<rugvip> target sdk has more to bo with UI
<rugvip> so meh

I'm making the patch select the oldest version so we get notified if we start using something new and the build breaks, and we can figure out that things won't work on Gingerbread (API level 9). Doesn't really matter which version we use in the end.

superdump commented 9 years ago

Merged.