EricssonResearch / openwebrtc-gst-plugins

OpenWebRTC specific GStreamer plugins
BSD 2-Clause "Simplified" License
51 stars 46 forks source link

please document SCReAM algorithm plugin #58

Open jonassmedegaard opened 7 years ago

jonassmedegaard commented 7 years ago

This project includes an implementation of the SCReAM - awesome!!!

It seems, however, that the implementation is somewhat behind the C++ library implementation at https://github.com/EricssonResearch/scream. I do understand that this is highly experimental code, and imagine that the main focus is therefore on development and consumption by others is not a high priority (if a priority/possibility at all). In any case, I suggest to add a (brief, at least) documentation on the status of this module - and if in a usable state then a concrete example.

Thanks for the exciting work you are doing in this field!

IngJohEricsson commented 7 years ago

Thanks. Yes it is true that the OWR implementation lags behind, hope that I will be able to update OWR one day.

Regards /Ingemar

From: Jonas Smedegaard [mailto:notifications@github.com] Sent: den 17 mars 2017 10:41 To: EricssonResearch/openwebrtc-gst-plugins openwebrtc-gst-plugins@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [EricssonResearch/openwebrtc-gst-plugins] please document SCReAM algorithm plugin (#58)

This project includes an implementation of the SCReAM - awesome!!!

It seems, however, that the implementation is somewhat behind the C++ library implementation at https://github.com/EricssonResearch/scream. I do understand that this is highly experimental code, and imagine that the main focus is therefore on development and consumption by others is not a high priority (if a priority/possibility at all). In any case, I suggest to add a (brief, at least) documentation on the status of this module - and if in a usable state then a concrete example.

Thanks for the exciting work you are doing in this field!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/EricssonResearch/openwebrtc-gst-plugins/issues/58, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKOdGH_sxRsWFOJi642wxPfRlhP948AWks5rmlUugaJpZM4MgXuY.

jonassmedegaard commented 7 years ago

Quoting IngJohEricsson (2017-03-20 14:25:43)

Yes it is true that the OWR implementation lags behind, hope that I will be able to update OWR one day.

Thanks for confirming, and great if you can find time to improve, but please not that the issue I raised here was a different - and simpler, I hope - one of mentioning at the front README.md that this project includes an implementation of SCReAM.

--

IngJohEricsson commented 7 years ago

OK, fixed this /Ingemar

From: Jonas Smedegaard [mailto:notifications@github.com] Sent: den 20 mars 2017 15:15 To: EricssonResearch/openwebrtc-gst-plugins openwebrtc-gst-plugins@noreply.github.com Cc: Ingemar Johansson S ingemar.s.johansson@ericsson.com; Comment comment@noreply.github.com Subject: Re: [EricssonResearch/openwebrtc-gst-plugins] please document SCReAM algorithm plugin (#58)

Quoting IngJohEricsson (2017-03-20 14:25:43)

Yes it is true that the OWR implementation lags behind, hope that I will be able to update OWR one day.

Thanks for confirming, and great if you can find time to improve, but please not that the issue I raised here was a different - and simpler, I hope - one of mentioning at the front README.md that this project includes an implementation of SCReAM.

--

[x] quote me freely [ ] ask before reusing [ ] keep private

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/EricssonResearch/openwebrtc-gst-plugins/issues/58#issuecomment-287771272, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKOdGPTwiUNA8N9iPBeCFN_U6jZxn54Lks5rnonGgaJpZM4MgXuY.

jonassmedegaard commented 7 years ago

Quoting IngJohEricsson (2017-03-22 09:32:07)

OK, fixed this

It seems you extended the README.md for https://github.com/EricssonResearch/scream

There is still no mention of SCReAM in the README.md for https://github.com/EricssonResearch/openwebrtc-gst-plugins.

--

IngJohEricsson commented 7 years ago

Yes.. sorry, misunderstood it. I will try to get time for a major overhaul of the owr-gst-plugin later on and fix the readme then.

/Ingemar

From: Jonas Smedegaard [mailto:notifications@github.com] Sent: den 22 mars 2017 19:16 To: EricssonResearch/openwebrtc-gst-plugins openwebrtc-gst-plugins@noreply.github.com Cc: Ingemar Johansson S ingemar.s.johansson@ericsson.com; Comment comment@noreply.github.com Subject: Re: [EricssonResearch/openwebrtc-gst-plugins] please document SCReAM algorithm plugin (#58)

Quoting IngJohEricsson (2017-03-22 09:32:07)

OK, fixed this

It seems you extended the README.md for https://github.com/EricssonResearch/scream

There is still no mention of SCReAM in the README.md for https://github.com/EricssonResearch/openwebrtc-gst-plugins.

--

[x] quote me freely [ ] ask before reusing [ ] keep private

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/EricssonResearch/openwebrtc-gst-plugins/issues/58#issuecomment-288491321, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKOdGK1JFp27iInaNwqOpSs7Js1sOUOVks5roWVcgaJpZM4MgXuY.

jonassmedegaard commented 7 years ago

Quoting IngJohEricsson (2017-03-24 10:25:14)

Yes.. sorry, misunderstood it. I will try to get time for a major overhaul of the owr-gst-plugin later on and fix the readme then.

Sounds great. Thanks!

--