EricssonResearch / openwebrtc-ios-sdk

SDK for adding OpenWebRTC to your iOS apps using CocoaPods
BSD 2-Clause "Simplified" License
69 stars 37 forks source link

implement candidateGenerate function and bring local candidate string back #45

Closed wangchauyan closed 8 years ago

wangchauyan commented 8 years ago

Hi,

I found this function, got_candidate, collect all local candidates and put them into a candidate list. And then put into a SDP offer. But in some applications, we do need to send each candidate respectively, and you also provide this protocol, candidateGenerate.

So, I implement this and send local candidate back to application for flexible using. Please check, and thanks.

stefanalund commented 8 years ago

I'll have a look beginning of next week. Thanks a lot.

wangchauyan commented 8 years ago

Sure, thanks a lot.

wangchauyan commented 8 years ago

ok, agree, that would be more safer. I will modify it and send to you again, thanks a lot.

wangchauyan commented 8 years ago

just set _selfView / _remoteView to nil after unregistering

wangchauyan commented 8 years ago

I just remove Todo comment / Debug Info line, please check this. Thanks.

stefanalund commented 8 years ago

Landed now, thanks again @wangchauyan!

wangchauyan commented 8 years ago

NP, thanks a lot.