EricssonResearch / scott-eu

SCOTT – Secure Connected Trustable Things
https://scottproject.eu/uc04-logistics-management-using-collaborative-robots-and-devops-methodologies/
Apache License 2.0
20 stars 8 forks source link

Executing a plan #116

Closed jramadeu closed 5 years ago

jramadeu commented 6 years ago

Give a high level plan like this

"id": "xyz",
"init": "initURI",
"goal": "finalURI",
"plan":[
            ["move", "turtlebot2i", "TagShelf#1"],
            ["pick", "turtlebot2i", "ShelfBody#1", "productRed"],
            ["pick", "turtlebot2i", "ShelfBody#1", "productGreen"],
            ["move", "turtlebot2i", "Waypoint_CB"],
            ["drop", "turtlebot2i", "ConveyorBeltBody", "productRed"]
       ]

The robot should move to TagShelf#1, pick productRed on ShelfBody#1 and so forth

jramadeu commented 6 years ago
jramadeu commented 6 years ago

changes on branch issue-116

jramadeu commented 5 years ago

@albertohata, I need some help from you.

I changed something in the project and now the robot can't reach a given position. When it tries to follow the plan it goes towards the waypoint but before it arrives the robot starts to rotate about its own axis and don't reach the waypoint. Can you help me?

albertohata commented 5 years ago

@albertohata, I need some help from you.

I changed something in the project and now the robot can't reach a given position. When it tries to follow the plan it goes towards the waypoint but before it arrives the robot starts to rotate about its own axis and don't reach the waypoint. Can you help me?

Sure. I will take a look. Probably some parameters of the navigation need to be adjusted.

albertohata commented 5 years ago

@albertohata, I need some help from you. I changed something in the project and now the robot can't reach a given position. When it tries to follow the plan it goes towards the waypoint but before it arrives the robot starts to rotate about its own axis and don't reach the waypoint. Can you help me?

Sure. I will take a look. Probably some parameters of the navigation need to be adjusted.

@jramadeu I tested in my machine and it worked correctly. Can you list the steps that you followed to run the move task? My guess is that some of the launch file is not properly loading the navigation configuration files in .../scott-eu/simulation-ros/src/turtlebot2i/turtlebot2i_navigation/config

jramadeu commented 5 years ago

On branch issue_116 and follow this steps:

  1. initialize roscore
  2. open v-rep
  3. load and run /turtlebot2i_description/v-rep_model/warehourse_turtlebot2i_v3_recharge.ttt
  4. roslaunch turtlebot2i_bringup turtlebot2i_full.launch
  5. pyhton src/plan_interpreter.py

If it still doesn't show any issue, try to change on the plan.json:

"id": "xyz", "init": "initURI", "goal": "finalURI", "plan":[ ["move", "turtlebot2i", "Waypoint_SH"], ["pick", "turtlebot2i", "ShelfBody", "productRed"], ["pick", "turtlebot2i", "ShelfBody", "productGreen"], ["move", "turtlebot2i", "Waypoint_CB#1"], ["drop", "turtlebot2i", "ConveyorBeltBody#1", "productRed"] ] }

albertohata commented 5 years ago

@jramadeu can you test the robot navigation again? I've updated the planner configuration.

jramadeu commented 5 years ago

Now the plan execution is more reliable, The robot is able to execute the pick and drop, although sometimes it fails. More important, most of time it will work.

Important! Due to tolerances with robot's navigation it will just pick one object. If we improve that, it will be able to pick more than one.

There're still things to be improved like: gripper pitch angle to grasp and robot navigation.

@albertohata, I notice you're keeping you're modification on task_manager here. I think this branch has too many commits and it's time to merge into master. After we merge we can create issues to keep working on plan execution, grasp pitch angle and improving the navigation. What do you think?

albertohata commented 5 years ago

Now the plan execution is more reliable, The robot is able to execute the pick and drop, although sometimes it fails. More important, most of time it will work.

Important! Due to tolerances with robot's navigation it will just pick one object. If we improve that, it will be able to pick more than one.

There're still things to be improved like: gripper pitch angle to grasp and robot navigation.

@albertohata, I notice you're keeping your modification on task_manager here. I think this branch has too many commits and it's time to merge into master. After we merge we can create issues to keep working on plan execution, grasp pitch angle and improving the navigation. What do you think?

Yes, I agree. I also have the same feeling. The planning part should be moved to another issue as it still has many work to do.

jramadeu commented 5 years ago

@albertohata, I was checking this issue and the respective branch. I found something that may deserves you attention.

I made the merge on master on 20Dec 2018 and the last commit merged was made on the same day, check here. But after that, you also pushed some commit to the same branch on 21Dec 2018 and 09Jan 2019, check here.

Therefore, these two recent commit were not merged. It's your decision to merge them or to just cherry-pick them to another branch.

albertohata commented 5 years ago

@albertohata, I was checking this issue and the respective branch. I found something that may deserves you attention.

I made the merge on master on 20Dec 2018 and the last commit merged was made on the same day, check here. But after that, you also pushed some commit to the same branch on 21Dec 2018 and 09Jan 2019, check here.

Therefore, these two recent commit were not merged. It's your decision to merge them or to just cherry-pick them to another branch.

@jramadeu If you don't mind, I will reopen this issue and continue working on the task worker and task manager. Otherwise I can create another issue/branch and continue working from there.

jramadeu commented 5 years ago

I don't mind at all.