Replace Hazelcast use with KB & initial impl f/Location Twin

EricssonResearch / scott-eu

SCOTT – Secure Connected Trustable Things

https://scottproject.eu/uc04-logistics-management-using-collaborative-robots-and-devops-methodologies/

Apache License 2.0

20 stars 8 forks source link

Replace Hazelcast use with KB & initial impl f/Location Twin #133

Closed berezovskyi closed 5 years ago

berezovskyi commented 5 years ago

The main objective of this PR is to get the Lyo services in shape for further development:

Removed Hazelcast and switched to using a KB through Lyo Store
Updated Twins & OSLC services to Lyo 4.0 (snapshot), closes #128
Updated Twins & OSLC services to JAX-RS 2.0, closes #150
Splits Swarm config into Dev & ERDC, closes #129
Baked config into Fuseki & Mosquitto images, closes #101

To that effect, WHC is operational; closes #40 and closes #53.

The PDDL ontology is used in the sandbox but the import feature was not used directly. Still, closing #52.

berezovskyi commented 5 years ago

@likelion this was quite an ambitious PR to implement the Location Service which would track TRS events for any position changes and notify its subscribers based on calculated distances.

Unfortunately, as I got to work on the task, I realised that there were many issues in the existing code plus it relied on Hazelcast. I am actually now almost ready to work on the Location Service. So, I would like to close this patch with all the fixes to the services for enabling "KB as a single source of truth" path we agreed with you late last year.

Please tell me what you think, I will remove the WIP tag as soon as I fix a few things on the WHC side.

berezovskyi commented 5 years ago

@likelion I think we should review it / merge it soon because I have done some refactoring yesterday and the number of files touched jumped from 140 to 240. I don't have much experience breaking up big patches but we can try if you have concrete suggestions.

berezovskyi commented 5 years ago

Okay, the patches from today fix the container push process: https://git.cf.ericsson.net/scott/scott-eu/-/jobs/

The pipeline failed too https://git.cf.ericsson.net/scott/scott-eu/pipelines/759. The root cause is an old Gitlab CI config, I have just pushed a fix for that and that deployed new things to the local Swarm.

I have created #145 to deal with extra images later.

@likeleon please check the deployment.

berezovskyi commented 5 years ago

@likelion the deploy was fixed but I am getting strange stuff like http://swarm.cf.ericsson.net/#/tasks/u6lsvnc1gbuaxconlq1dyyzi6

berezovskyi commented 5 years ago

@likelion logs are also AWOL in the Portainer

berezovskyi commented 5 years ago

@likelion what shall we do with this monster? :)

berezovskyi commented 5 years ago

@likelion should we perhaps relax the requirement to get at least one review before merging? :)

berezovskyi commented 5 years ago

@likelion the deploy is fixed now.

But we have been hit by #150 after JAX-RS 2.0 supported was merged into master in Lyo.

berezovskyi commented 5 years ago

All systems in Portainer are green, merging.

berezovskyi commented 5 years ago

That was a force-push of a rebase. I prefer squashes, but that's too much to squash IMO.