EricssonResearch / scott-eu

SCOTT – Secure Connected Trustable Things
https://scottproject.eu/uc04-logistics-management-using-collaborative-robots-and-devops-methodologies/
Apache License 2.0
20 stars 8 forks source link

"LICENSE REMOVED FOR BREVITY" is not OK #87

Open berezovskyi opened 6 years ago

berezovskyi commented 6 years ago

https://github.com/EricssonResearch/scott-eu/blob/simulation-ros/simulation-ros/src/turtlebot2i/turtlebot2i_navigation/src/navigation.py#L2

License header is there because it is required by the license. Could you please help me restore it?

albertohata commented 6 years ago

I copied this code from a website and modified it. Do we have any default license header that we must include in the codes? Otherwise I can remove this line.

berezovskyi commented 6 years ago

The files we create, must have the Apache 2.0 license header. If we did not create the files, we must leave the license that those files had.

albertohata commented 6 years ago

I think we also can close this one... I have already fixed this particular one.

berezovskyi commented 6 years ago

I am not sure. Can you please do a search for any GPL strings, please?

–Andrew. (sent from my phone)

On 4 Jul 2018, at 13:16, albertohata notifications@github.com wrote:

I think we also can close this one... I have already fixed this particular one.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

albertohata commented 6 years ago

There are some occurrences of GPL, but they are related to the remote API of the V-REP, which is also related to this question you made: https://github.com/CoppeliaRobotics/remoteApiBindings/issues/2. In this, they said that they will move to BSD license. But, until now they didn't change the license...

albertohata commented 6 years ago

In the V-REP github there is a licence.txt file which says that they use BSD license: https://github.com/CoppeliaRobotics/remoteApiBindings/blob/master/license.txt But, the header of the codes still contains GPL header.

berezovskyi commented 6 years ago

We can’t merge GPL in. Unless we want to relicense our SCOTT sandbox under GPL.

–Andrew. (sent from my phone)

On 4 Jul 2018, at 16:14, albertohata notifications@github.com wrote:

In the V-REP github there is a licence.txt file which says that they use BSD license: https://github.com/CoppeliaRobotics/remoteApiBindings/blob/master/license.txt But, the header of the codes still contains GPL header.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

KRaizer commented 6 years ago

The license has been updated to BSD recently: https://github.com/CoppeliaRobotics/remoteApiBindings/blob/master/license.txt

So the task here would be to get the updated code: https://github.com/CoppeliaRobotics/remoteApiBindings/blob/master/java/java/coppelia/remoteApi.java

Correct?

berezovskyi commented 5 years ago

@KRaizer @jramadeu did we actually update our repo contents to reflect their change? Can we close this one?

KRaizer commented 5 years ago

I understand it was GPL, and then Coppelia changed it to BSD later on. Alberto ( @albertohata ), are we still using the code from the time it was GPL?