IngJohEricsson
commented
5 years ago Hi
You are indeed correct in that the code that scales back the target rate in case the RTP queue builds up, described in RFC8298, is not in place in the code. The reason is that I realize that this feature sometimes did more harm than gain.
There is however some adjustment based on the RTP queue build up
https://github.com/EricssonResearch/scream/blob/master/code/ScreamTx.cpp#L1957 https://github.com/EricssonResearch/scream/blob/master/code/ScreamTx.cpp#L1957
The rate_transmit and rate_ack is combined in
https://github.com/EricssonResearch/scream/blob/master/code/ScreamTx.cpp#L1787 https://github.com/EricssonResearch/scream/blob/master/code/ScreamTx.cpp#L1787
BR
/Ingemar
From: j-licht notifications@github.com Sent: den 24 juni 2019 10:36 To: EricssonResearch/scream scream@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [EricssonResearch/scream] Implementation Status of the RFC especially media rate control (#20)
Hi,
if I compare the RFC8298 media rate control algorithm with the implementation, I didn't find features like "Force a slight reduction in bitrate if RTP queue builds up". And I didn't find the dependency through the rate_transmit and rate_ack.
If this is already implemented, can you please point me to the code. Thanks.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://protect2.fireeye.com/url?k=36804c4a-6a0a86f4-36800cd1-869a17b5b21b-07ef6f34c73681da&q=1&u=https%3A%2F%2Fgithub.com%2FEricssonResearch%2Fscream%2Fissues%2F20%3Femail_source%3Dnotifications%26email_token%3DACRZ2GFSC44GXVNCXX3J6G3P4CBOXA5CNFSM4H24JOG2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G3HNBBQ , or mute the thread https://protect2.fireeye.com/url?k=22a7409f-7e2d8a21-22a70004-869a17b5b21b-021f5ec68c0069e8&q=1&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACRZ2GDRKMSPCCUIXAKRFSLP4CBOXANCNFSM4H24JOGQ .
Hi,
if I compare the RFC8298 media rate control algorithm with the implementation, I didn't find features like "Force a slight reduction in bitrate if RTP queue builds up". And I didn't find the dependency through the rate_transmit and rate_ack.
If this is already implemented, can you please point me to the code. Thanks.