EricssonResearch / scream

SCReAM - Mobile optimised congestion control algorithm
BSD 2-Clause "Simplified" License
174 stars 53 forks source link

Duplicated source files #32

Closed mirabilos closed 4 years ago

mirabilos commented 4 years ago

Asides from https://github.com/EricssonResearch/scream/issues/29 there are more duplicated source files around:

bw-test-tool/code/ contains copies (old? modified? both?) of:

These should (probably?) be replaced by symbolic links as well, and the tool adapted.

gscream/gst-gscreamtx/gst-plugin/src/ duplicates these:

The others are already symlinked. Maybe these two also should?

code/gscream/gst-gscreamtx/gst-plugin/src/ contains two copies…

I can provide a pull request fixing these, but I cannot estimate the changes needed to the bw-test-tool to adapt.

mirabilos commented 4 years ago

RtpQueue.{cpp,h} indeed must be different. I made these files as close to other, respectively, as possible though to ease further keeping them synchronised with changes.

mirabilos commented 4 years ago

The relevant changes are merged, and the only question still open is also carried in #26, so I’m closing this here to not clutter the issues list.