Round 2 of fixes - Githubissues

EricssonResearch / scream

SCReAM - Mobile optimised congestion control algorithm

BSD 2-Clause "Simplified" License

174 stars 53 forks source link

Round 2 of fixes #34

Closed mirabilos closed 2 years ago

mirabilos commented 4 years ago

Hi @IngJohEricsson,

this is round 2 of my fixes. I verified I can reach 200+ kbps with this (now that I know it’s bit, not bytes), and I did not symlink the files again.

fix the file types issue, so this can actually be checked out on Unix/Linux
clean up whitespace, const, comments, UINT32_MAX, etc. again
fix unreachable statement (matches the other two RtpQueue.cpp files in the repository)
add the build instructions to README.md which I already prepared

mirabilos commented 4 years ago

@IngJohEricsson I’ve rebased my changes you already approved on today’s latest master branch, converted symlinks to includes (as it’s clear symlinks won’t work) and fixed gscream to at least compile. Please merge ;-)

mirabilos commented 2 years ago

superceded by #46